configuration issue #93 #1024
Open
configuration issue #93 #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anway Durge <[email protected]>
Signed-off-by: Anway Durge <[email protected]>
nscuro
requested changes
Oct 22, 2024
| @@ -69,6 +69,13 @@ axios | |||
| createVueApp(); | |||
| }); | |||
|
|
|||
| const faviconPath = process.env.DT_FAVICON_PATH || '/default/favicon.ico'; | |||
There was a problem hiding this comment.
I fear this won't work.
Certain environment variables defined at build-time can be statically embedded, but DT_FAVICON_PATH doesn't fall under any of them. Also, even if it was, it would mean that users would have to re-compile the project if they want to change the favicon, which is not what we want.
Is there another way to achieve this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed Issue
Additional Details
Checklist